[PATCH] spi-nor: sfdp: Allow configuring unknown flashes using SFDP

Pratyush Yadav p.yadav at ti.com
Fri May 21 02:55:05 PDT 2021


On 20/05/21 06:07PM, Petr Malat wrote:
> This change allows adding a support for flashes with correct SFDP
> without recompilation of the kernel by setting sfdp-compatible property
> in their node. Alternatively, sfdp_compatible module option can be used
> to list JEDEC IDs of flashes, whose SFDP can be trusted. Star "*" can
> be used to match all JEDEC IDs.

I have skimmed through the patch. Before I look at it more closely, I 
want to understand the use case for this patch. Why would you not want 
to recompile the kernel when adding support for new hardware? Do you 
want the ability to support flashes on devices that have already been 
deployed in the field? Is it something that comes up frequently?

Then comes the question of how do you get the flash to probe if it is 
not present in device tree? And if you are able to update the device 
tree then you should also be able to update the kernel.

Have you tested this with any flash? If so, with which one?

> 
> Signed-off-by: Petr Malat <oss at malat.biz>
> ---
>  .../devicetree/bindings/mtd/jedec,spi-nor.txt |  3 +

This file has been converted to yaml since at least 5.12-rc1. Please 
update your kernel sources and rebase your patches.

>  drivers/mtd/spi-nor/core.c                    | 86 +++++++++++--------
>  drivers/mtd/spi-nor/core.h                    |  4 +
>  drivers/mtd/spi-nor/sfdp.c                    | 66 ++++++++++++++
>  drivers/mtd/spi-nor/sfdp.h                    |  2 +
>  5 files changed, 126 insertions(+), 35 deletions(-)

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.



More information about the linux-mtd mailing list