[PATCH v5 2/2] spi: mxic: patch for octal DTR mode support

[zhengxunli at mxic.com.tw]

Hi,

"Pratyush Yadav" <p.yadav at ti.com> wrote on 2021/05/18 上午 12:06:30:

> "Pratyush Yadav" <p.yadav at ti.com> 
> 2021/05/18 上午 12:06
> 
> To
> 
> "Zhengxun Li" <zhengxunli at mxic.com.tw>, 
> 
> cc
> 
> <linux-mtd at lists.infradead.org>, <linux-spi at vger.kernel.org>, 
> <tudor.ambarus at microchip.com>, <miquel.raynal at bootlin.com>, 
> <broonie at kernel.org>, <jaimeliao at mxic.com.tw>
> 
> Subject
> 
> Re: [PATCH v5 2/2] spi: mxic: patch for octal DTR mode support
> 
> On 17/05/21 02:14PM, Zhengxun Li wrote:
> > Driver patch for octal DTR mode support.
> > 
> > Owing to the spi_mem_default_supports_op() is not support dtr
> > operation. Based on Pratyush patch "spi: spi-mem: add spi_mem_dtr
> 
> I don't like the "Based on Pratyush patch". Please mention the commit 
> hash so it is much easier to find later. For example, saying based on 
> commit 539cf68cd51b (spi: spi-mem: add spi_mem_dtr_supports_op(), 
> 2021-02-04) is much better.
> 
> But while we are on this topic, I don't think it is needed all that 
> much. People use pre-existing APIs all the time. I don't see any need to 

> specifically point it out.  So I think saying "Call 
> spi_mem_dtr_supports_op() to ..." is better.

Thanks for your suggestion.
 
> > _supports_op()" add spi_mem_dtr_supports_op() to support dtr and
> > keep checking the buswidth and command bytes.
> > 
> > Signed-off-by: Zhengxun Li <zhengxunli at mxic.com.tw>
> > ---

Thanks,
Zhengxun


CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information 
and/or personal data, which is protected by applicable laws. Please be 
reminded that duplication, disclosure, distribution, or use of this e-mail 
(and/or its attachments) or any part thereof is prohibited. If you receive 
this e-mail in error, please notify us immediately and delete this mail as 
well as its attachment(s) from your system. In addition, please be 
informed that collection, processing, and/or use of personal data is 
prohibited unless expressly permitted by personal data protection laws. 
Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================



============================================================================

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================