[PATCH 0/2] Fix double counting of S/W ECC engines' ECC stat
ycllin at mxic.com.tw
ycllin at mxic.com.tw
Wed May 12 19:11:02 PDT 2021
> "Miquel Raynal" <miquel.raynal at bootlin.com>
<deleted>
>
> Good catch!
>
> However I don't think the current fix is valid because these engines
> are meant to be used by the raw NAND core as well, I propose something
> like the below, can you please tell me if it works as expected? (not
> even build tested)
>
> Thanks,
> Miquèl
>
>
<deleted>
Thanks for your work.
I tested the two patches(yours and mine) separately in our environment:
1) MXIC NFC(&raw NAND),2) MXIC SPI host(&SPI-NAND) with S/W BCH engine.
Both patches are valid(using nandtest/nandbiterrs, values of ecc_stats are
normal).
This seems to be because the function(nand_ecc_sw_bch_finish_io_req()
in ecc-sw-bch.c) that would increase the ecc_stats counter is not used
in the raw NAND world. Am I misunderstanding or is it platform dependency?
BTW, I think your modification should be more in line with the design
spirit
of generic ECC engine framework.
Thanks,
YouChing
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information
and/or personal data, which is protected by applicable laws. Please be
reminded that duplication, disclosure, distribution, or use of this e-mail
(and/or its attachments) or any part thereof is prohibited. If you receive
this e-mail in error, please notify us immediately and delete this mail as
well as its attachment(s) from your system. In addition, please be
informed that collection, processing, and/or use of personal data is
prohibited unless expressly permitted by personal data protection laws.
Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
============================================================================
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
More information about the linux-mtd
mailing list