[PATCH] mtd: parsers: ofpart: fix parsing subpartitions

Miquel Raynal miquel.raynal at bootlin.com
Mon May 10 02:09:00 PDT 2021


On Sat, 2021-05-08 at 17:32:14 UTC, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= wrote:
> From: Rafał Miłecki <rafal at milecki.pl>
> 
> ofpart was recently patched to not scan random partition nodes as
> subpartitions. That change unfortunately broke scanning valid
> subpartitions like:
> 
> partitions {
> 	compatible = "fixed-partitions";
> 	#address-cells = <1>;
> 	#size-cells = <1>;
> 
> 	partition at 0 {
> 		compatible = "fixed-partitions";
> 		label = "bootloader";
> 		reg = <0x0 0x100000>;
> 
> 		partition at 0 {
> 			label = "config";
> 			reg = <0x80000 0x80000>;
> 		};
> 	};
> };
> 
> Fix that regression by adding 1 more code path. We actually need 3
> conditional blocks to support 3 possible cases. This change also makes
> code easier to understand & follow.
> 
> Reported-by: David Bauer <mail at david-bauer.net>
> Fixes: 2d751203aacf ("mtd: parsers: ofpart: limit parsing of deprecated DT syntax
> Signed-off-by: Rafał Miłecki <rafal at milecki.pl>
> Tested-by: Andrew Cameron <apcameron at softhome.net>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel



More information about the linux-mtd mailing list