[PATCH] mtd: mchp48l640: silence some uninitialized variable warnings

Colin Ian King colin.king at canonical.com
Tue Jun 22 08:39:11 PDT 2021


On 22/06/2021 16:31, Fabio Estevam wrote:
> On Sat, Jun 19, 2021 at 3:23 AM Heiko Schocher <hs at denx.de> wrote:
>>
>> Hello Dan,
>>
>> On 18.06.21 15:42, Dan Carpenter wrote:
>>> Smatch complains that zero length read/writes will lead to an
>>> uninitalized return value.  I don't know if that's possible, but
>>> it's nicer to return a zero literal anyway so let's do that.
>>>
>>> Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM")
>>> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>>> ---
>>> People, when we add a new driver can we make sure the first commit uses
>>> the new prefered subsystem prefix?  For example,
>>>
>>> "mtd: mchp48l640: add support for microchip 48l640 EERAM"
>>>       ^^^^^^^^^^
>>> Otherwise it's not clear to me what I should use as a patch prefix.
>>
>> Ok, sorry...
>>
>> Hmm... Colin already sent a fix for this, see:
>>
>> https://lists.infradead.org/pipermail/linux-mtd/2021-June/087140.html
> 
> Yes, both patches work, but I think Dan's solution is a bit clearer, so:
> 
> Reviewed-by: Fabio Estevam <festevam at gmail.com>
> 
> Thanks
> 
Yep, I'm good with that.




More information about the linux-mtd mailing list