[PATCH 6/7] mtd: spi-nor: manuf-id-collisions: Add support for xt25f128b

[Chris Morgan]

On Tue, Jul 06, 2021 at 06:39:09AM +0000, Tudor.Ambarus at microchip.com wrote:
> On 7/6/21 9:28 AM, Pratyush Yadav wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > On 02/07/21 05:41PM, Tudor Ambarus wrote:
> >> Flash does not support continuation codes and may collide with a flash
> >> of other manufacturer, Intersil being an example .
> >>
> >> This flash addition is just for demonstration purposes. As I don't
> >> have the flash, I assumed that it supports SFDP.
> > 
> > I found a datasheet for this flash via Google [0]. It does indeed
> > support SFDP (section 6.36). The data in the SFDP table is not listed so
> > we can't say if it is completely correct though.
> > 
> > I am not sure if we should add support for an untested flash. We ask
> > people to only add tested flashes and I think it is a good principle to
> > stick to.
> > 
> 
> We won't apply it if not tested and without the SFDP tables dump. This applies
> for all the flashes. Chris Morgan (in Cc) proposed to introduce support for this
> flash a while ago. If we get support from Chris, we'll consider applying it, if not,
> not.

I've tested the xt25f128b driver here, it works.  Note though that I
think the flags of SPI_NOR_HAS_LOCK and SPI_NOR_HAS_TB may not be
needed, as I believe on a cursory glance they correspond to different
bits than the datasheet has defined.

Also note that I have previously dumped the SFDC table here, if you need a more
recent dump please let me know:

http://lists.infradead.org/pipermail/linux-mtd/2021-April/085976.html

0000000 4653 5044 0100 ff01 0000 0901 0030 ff00
0000010 000b 0301 0060 ff00 ffff ffff ffff ffff
0000020 ffff ffff ffff ffff ffff ffff ffff ffff
0000030 20e5 fff1 ffff 07ff eb44 6b08 3b08 bb42
0000040 ffee ffff ffff ff00 ffff ff00 200c 520f
0000050 d810 ff00 ffff ffff ffff ffff ffff ffff
0000060 3600 2700 f99f 6477 e8d9 ffff

Thank you.