[PATCH 4/7] mtd: spi-nor: macronix: Handle ID collision b/w MX25L12805D and MX25L12835F

[Tudor.Ambarus at microchip.com]

On 7/5/21 1:45 PM, Heiko Thiery wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hi Tudor,
> 
> Am Mo., 5. Juli 2021 um 09:51 Uhr schrieb <Tudor.Ambarus at microchip.com>:
>>
>> On 7/2/21 5:41 PM, Tudor Ambarus wrote:
>>> +     { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, SPI_NOR_PARSE_SFDP |
>>> +                           SECT_4K | SPI_NOR_HAS_LOCK | SPI_NOR_4BIT_BP)
>>
>> I should have removed SECT_4K, since 4k erase should be set when parsing SFDP.
>> If SFDP is wrong, we can amend it in the post_bfpt hook.
> 
> But what about the 4K support for the "old" mx25l12805d that does not
> support reading SFDP? As far as I understand, the post_bfpt hook is
> only called when the SFDP was successfully read and this would mean
> the "old" one would never get this setting.

You're absolutely correct, we'll keep SECT_4K in order to not break backward
compatibility with the old flash. I thought it was a new flash addition. That's
me replying to emails while being distracted. Anyway, I'll have a documentation
written somewhere about guidelines on how to propose new flash addition or how
to handle flash collisions. Everything seems fine here.