[PATCH 4/8] ubifs: do not ubifs_inode() on potentially NULL pointer
Sascha Hauer
s.hauer at pengutronix.de
Fri Jan 22 10:15:32 EST 2021
new_inode() may return NULL, so only derefence the return inode when
non NULL. This is merely a cleanup as calling ubifs_inode() on a NULL
pointer doesn't do any harm, only using the return value would.
Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
---
fs/ubifs/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index 9a6b8660425a..cc1d7f5085ab 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -82,10 +82,10 @@ struct inode *ubifs_new_inode(struct ubifs_info *c, struct inode *dir,
bool encrypted = false;
inode = new_inode(c->vfs_sb);
- ui = ubifs_inode(inode);
if (!inode)
return ERR_PTR(-ENOMEM);
+ ui = ubifs_inode(inode);
/*
* Set 'S_NOCMTIME' to prevent VFS form updating [mc]time of inodes and
* marking them dirty in file write path (see 'file_update_time()').
--
2.20.1
More information about the linux-mtd
mailing list