[PATCH 0/3] fixes for ubifs xattr operations

Hou Tao houtao1 at huawei.com
Tue Feb 23 21:49:07 EST 2021


On 11/3/2020 4:19 PM, Richard Weinberger wrote:
> On Tue, Nov 3, 2020 at 3:04 AM Hou Tao <houtao1 at huawei.com> wrote:
>> Hi,
>> On 2020/11/1 5:10, Richard Weinberger wrote:
>>> Tao,
>>> On Fri, Oct 23, 2020 at 9:25 AM Hou Tao <houtao1 at huawei.com> wrote:
>>>> Hi Richard,
>>>> I have written two xfstest cases [1] for these fixes three months ago, could you please
>>>> check whether the proposed solution is OK ?
>>> Thanks for your time and reminding me about this issue!
>>> I agree that this is a problem but I'm not sure whether the lockless
>>> solution is the right path to go.
>>> DId you try the locking approach?
>> Yes. Adding an extra lock for xattr ops also works. I will post a V2 soon.
> Sounds promising!
Sorry for the long delay.
> Btw. you think of an extra rw lock because host->ui_mutex is too cause
> grained and
> would block xattr parallel read operations?

Yes, the locking order is another concern. But we can change host->ui_mutex to a rw lock

if both the locking order and the granularity are OK. I will check both.



More information about the linux-mtd mailing list