[PATCH 2/2] mtd: parsers: trx: Remove dependency to BRCM architectures

Hauke Mehrtens hauke at hauke-m.de
Sun Apr 18 18:03:32 BST 2021


On 3/18/21 7:45 AM, Rafał Miłecki wrote:
> On 15.03.2021 18:07, Hauke Mehrtens wrote:
>> Buffalo uses the TRX partition format also on Mediatek SoCs.
>>
>> Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
>> ---
>>   drivers/mtd/parsers/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/parsers/Kconfig b/drivers/mtd/parsers/Kconfig
>> index d90c30229052..6242903d8844 100644
>> --- a/drivers/mtd/parsers/Kconfig
>> +++ b/drivers/mtd/parsers/Kconfig
>> @@ -96,7 +96,7 @@ config MTD_AFS_PARTS
>>   config MTD_PARSER_TRX
>>       tristate "Parser for TRX format partitions"
>> -    depends on MTD && (BCM47XX || ARCH_BCM_5301X || COMPILE_TEST)
>> +    depends on MTD
>>       help
>>         TRX is a firmware format used by Broadcom on their devices. It
>>         may contain up to 3/4 partitions (depending on the version).
>>
> 
> Please check Documentation/kbuild/kconfig-language.rst and commit
> 18084e435ff6 ("Documentation/kbuild: Document platform dependency
> practises")
> 
> I think you should rather add platform to DEPENDS.

Ok I will add a dependency to ARCH_MEDIATEK. I think Buffalo also used 
this on some Mediatek/ralink MIPS devices, but they are not supported 
upstream yet.

Hauke



More information about the linux-mtd mailing list