[PATCH] mtd: remove unneeded return statment in mtdswap_write_marker()

Luo Meng luomeng12 at huawei.com
Fri Apr 9 08:56:22 BST 2021


It should be impossible 'ret !=0' and 'ops.oobretlen != ops.ooblen',
So remove the unneeded return statment.

Reported-by: Hulk Robot <hulkci at huawei.com>
Signed-off-by: Luo Meng <luomeng12 at huawei.com>
---
 drivers/mtd/mtdswap.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c
index 795dec4483c2..12bacb4ae9de 100644
--- a/drivers/mtd/mtdswap.c
+++ b/drivers/mtd/mtdswap.c
@@ -398,12 +398,10 @@ static int mtdswap_write_marker(struct mtdswap_dev *d, struct swap_eb *eb,
 		return ret;
 	}
 
-	if (ops.oobretlen != ops.ooblen) {
+	if (ops.oobretlen != ops.ooblen)
 		dev_warn(d->dev, "Short OOB write for block at %08llx: "
 			"%zd not %zd\n",
 			offset, ops.oobretlen, ops.ooblen);
-		return ret;
-	}
 
 	return 0;
 }
-- 
2.25.4




More information about the linux-mtd mailing list