[PATCH] ubifs: journal: Make sure to not dirty twice for auth nodes

Sascha Hauer s.hauer at pengutronix.de
Tue Sep 29 04:32:32 EDT 2020


On Mon, Sep 28, 2020 at 09:06:12PM +0200, Richard Weinberger wrote:
> When removing the last reference of an inode the size of an auth node
> is already part of write_len. So we must not call ubifs_add_auth_dirt().
> Call it only when needed.
> 
> Cc: <stable at vger.kernel.org>
> Cc: Sascha Hauer <s.hauer at pengutronix.de>
> Cc: Kristof Havasi <havasiefr at gmail.com>
> Fixes: 6a98bc4614de ("ubifs: Add authentication nodes to journal")
> Reported-by: Kristof Havasi <havasiefr at gmail.com>
> Signed-off-by: Richard Weinberger <richard at nod.at>

Looked at the code until I understood what the problem is and how it is
fixed, so:

Reviewed-by: Sascha Hauer <s.hauer at pengutronix.de>

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the linux-mtd mailing list