[PATCH 1/2] Revert "mtd: spi-nor: Disable the flash quad mode in spi_nor_restore()"

Vignesh Raghavendra vigneshr at ti.com
Thu Sep 17 05:20:10 EDT 2020


On Fri, 4 Sep 2020 15:47:19 +0800, Yicong Yang wrote:
> Previous patch intends to restore the flash's QE bit when removed/shutdown,
> but may have some problems and break the flash:
> 
> - for those originally in Quad mode, this patch will clear the QE bit
>   when unloaded the flash, which is incorrect.
> - even with above problem solved, it may still break the flash as some
>   flash's QE bit is non-volatile and lots of set/reset will wear out
>   the bit.
> - the restore method cannot be proved to be valid as if a hard
>   reset or accident crash happened, the spi_nor_restore() won't be
>   performed the the QE bit will not be restored as we expected to.
> 
> [...]

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks!
[1/2] Revert "mtd: spi-nor: Disable the flash quad mode in spi_nor_restore()"
      https://git.kernel.org/mtd/c/7d90a9b269
[2/2] Revert "mtd: spi-nor: Add capability to disable flash quad mode"
      https://git.kernel.org/mtd/c/1afc0c89f6

--
Regards
Vignesh




More information about the linux-mtd mailing list