[PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments

Miquel Raynal miquel.raynal at bootlin.com
Wed Oct 28 06:03:18 EDT 2020


Hi Sergei,

Sergei Antonov <saproj at gmail.com> wrote on Wed, 28 Oct 2020 12:49:40
+0300:

> Arguments 'infolen' and 'datalen' to meson_nfc_dma_buffer_release() were mixed up.
> 
> Fixes: 8fae856c53500 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
> Cc: stable at vger.kernel.org
> Signed-off-by: Sergei Antonov <saproj at gmail.com>

This patch looks good to me. Next time you send a new iteration of a
patch, please use [PATCH v2] in the subject prefix and also add a
changelog below the three dashes.

(your other patch to fix the style is still welcome)

> ---
>  drivers/mtd/nand/raw/meson_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index 48e6dac96be6..a76afea6ea77 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -510,7 +510,7 @@ static int meson_nfc_dma_buffer_setup(struct nand_chip *nand, void *databuf,
>  }
>  
>  static void meson_nfc_dma_buffer_release(struct nand_chip *nand,
> -					 int infolen, int datalen,
> +					 int datalen, int infolen,
>  					 enum dma_data_direction dir)
>  {
>  	struct meson_nfc *nfc = nand_get_controller_data(nand);

Thanks,
Miquèl



More information about the linux-mtd mailing list