[PATCH v3] mtd: rawnand: mxc: Move the ECC engine initialization to the right place

Miquel Raynal miquel.raynal at bootlin.com
Mon Oct 26 13:49:26 EDT 2020


Hello,

Miquel Raynal <miquel.raynal at bootlin.com> wrote on Mon, 26 Oct 2020
18:45:32 +0100:

> On Fri, 2020-10-16 at 21:36:13 UTC, Fabio Estevam wrote:
> > No ECC initialization should happen during the host controller probe.
> > 
> > In fact, we need the probe function to call nand_scan() in order to:
> > 
> > - identify the device, its capabilities and constraints (nand_scan_ident())
> > - configure the ECC engine accordingly (->attach_chip())
> > - scan its content and prepare the core (nand_scan_tail())
> > 
> > Moving these lines to mxcnd_attach_chip() fixes a regression caused by
> > a previous commit supposed to clarify these steps.
> > 
> > When moving the ECC initialization from probe() to attach(), get rid
> > of the pdata usage to determine the engine type and let the core decide
> > instead.
> > 
> > Tested on a imx27-pdk board.
> > 
> > Reported-by: Fabio Estevam <festevam at gmail.com>
> > Co-developed-by: Miquel Raynal <miquel.raynal at bootlin.com>
> > Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
> > Signed-off-by: Fabio Estevam <festevam at gmail.com>
> > Tested-by: Sascha Hauer <s.hauer at pengutronix.de>
> > Tested-by: Martin Kaiser <martin at kaiser.cx>  

This patch should be in next by tomorrow+.

I moved my SoB to the bottom as Fabio is now the author of the patch
and added the Fixes tag.

Cheers,
Miquèl



More information about the linux-mtd mailing list