[PATCH v2] mtd: rawnand: ifc: Move the ECC engine initialization to the right place

Miquel Raynal miquel.raynal at bootlin.com
Mon Oct 26 13:45:25 EDT 2020


On Fri, 2020-10-16 at 13:26:26 UTC, Fabio Estevam wrote:
> No ECC initialization should happen during the host controller probe.
> 
> In fact, we need the probe function to call nand_scan() in order to:
> - identify the device, its capabilities and constraints (nand_scan_ident())
> - configure the ECC engine accordingly (->attach_chip())
> - scan its content and prepare the core (nand_scan_tail())
> 
> Moving these lines to fsl_ifc_attach_chip() fixes a regression caused by
> a previous commit supposed to clarify these steps.
> 
> Based on a fix done for the mxc_nand driver by Miquel Raynal.
> 
> Reported-by: Han Xu <xhnjupt at gmail.com>
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> Tested-by: Han Xu <xhnjupt at gmail.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel



More information about the linux-mtd mailing list