[PATCH 30/45] block: remove the nr_sects field in struct hd_struct
Hannes Reinecke
hare at suse.de
Mon Nov 30 02:39:46 EST 2020
On 11/28/20 5:14 PM, Christoph Hellwig wrote:
> Now that the hd_struct always has a block device attached to it, there is
> no need for having two size field that just get out of sync.
>
> Additionally the field in hd_struct did not use proper serialization,
> possibly allowing for torn writes. By only using the block_device field
> this problem also gets fixed.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Acked-by: Coly Li <colyli at suse.de> [bcache]
> Acked-by: Chao Yu <yuchao0 at huawei.com> [f2fs]
> ---
> block/bio.c | 4 +-
> block/blk-core.c | 2 +-
> block/blk.h | 53 ----------------------
> block/genhd.c | 55 +++++++++++-----------
> block/partitions/core.c | 17 ++++---
> drivers/block/loop.c | 1 -
> drivers/block/nbd.c | 2 +-
> drivers/block/xen-blkback/common.h | 4 +-
> drivers/md/bcache/super.c | 2 +-
> drivers/s390/block/dasd_ioctl.c | 4 +-
> drivers/target/target_core_pscsi.c | 5 +-
> fs/block_dev.c | 73 +-----------------------------
> fs/f2fs/super.c | 2 +-
> fs/pstore/blk.c | 2 +-
> include/linux/genhd.h | 29 +++---------
> kernel/trace/blktrace.c | 2 +-
> 16 files changed, 61 insertions(+), 196 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare at suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare at suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
More information about the linux-mtd
mailing list