[PATCH 19/20] bcache: remove a superflous lookup_bdev all
Christoph Hellwig
hch at lst.de
Wed Nov 18 11:24:47 EST 2020
On Wed, Nov 18, 2020 at 04:54:51PM +0800, Coly Li wrote:
> On 11/18/20 4:47 PM, Christoph Hellwig wrote:
> > Don't bother to call lookup_bdev for just a slightly different error
> > message without any functional change.
> >
> > Signed-off-by: Christoph Hellwig <hch at lst.de>ist
>
> Hi Christoph,
>
> NACK. This removing error message is frequently triggered and observed,
> and distinct a busy device and an already registered device is important
> (the first one is critical error and second one is not).
>
> Remove such error message will be a functional regression.
I can probably keep it, the amount of code to prettiefy an error message
seems excessive, though.
More information about the linux-mtd
mailing list