[PATCH v11 1/2] dt-bindings: mtd: Document nand-ecc-engine

Rob Herring robh at kernel.org
Mon Jun 29 19:00:54 EDT 2020


On Fri, Jun 26, 2020 at 09:13:56AM +0200, Miquel Raynal wrote:
> This property is needed to precisely point to the hardware ECC engine
> to use when there are several of them available. Here, hardware also
> refers to the on-die possibility.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
> ---
>  .../devicetree/bindings/mtd/nand-controller.yaml     | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> index 4a0798247d2d..0969d2e6720b 100644
> --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml
> @@ -56,6 +56,18 @@ patternProperties:
>            (Linux will handle the calculations). soft_bch is deprecated
>            and should be replaced by soft and nand-ecc-algo.
>  
> +      nand-ecc-engine:
> +        maxItems: 1

maxItems is for arrays and this is a phandle. It needs a type reference.

> +        description:

You need '|' at the end if you want the formatting preserved.

> +	  A phandle on the hardware ECC engine if any. There are

A tab is not valid YAML. 

> +          basically three possibilities:
> +          1/ The ECC engine is part of the NAND controller, in this
> +          case the phandle should reference the parent node.
> +          2/ The ECC engine is part of the NAND part (on-die), in this
> +          case the phandle should reference the node itself.
> +          3/ The ECC engine is external, in this case the phandle should
> +          reference the specific ECC engine node.
> +
>        nand-ecc-placement:
>          allOf:
>            - $ref: /schemas/types.yaml#/definitions/string
> -- 
> 2.20.1
> 



More information about the linux-mtd mailing list