[PATCH v2 2/3] spi: Add HiSilicon v3xx SPI NOR flash controller driver
john.garry at huawei.com
Fri Jan 10 03:55:37 PST 2020
On 09/01/2020 21:28, Mark Brown wrote:
> On Thu, Jan 09, 2020 at 03:54:00PM +0000, John Garry wrote:
>> From checking acpi_spi_add_resource() or anywhere else, I cannot see how
>> SPI_RX_DUAL or the others are set for spi_device.mode. What am I missing?
>> Are these just not supported yet for ACPI? Or should the spi-nor code not be
>> relying on this since we should be able to get this info from the SPI NOR
> I'm not aware of any work on integrating this sort of stuff into ACPI
> platforms so I think it's just not yet supported in ACPI. I'm not
> really sure what would be idiomatic for ACPI, figuring it out from what
> the part supports might well be idiomatic there though I don't know how
> common it is for people not to wire up all the data lines even if both
> controller and device support wider transfers.
OK, so I guess that is why we require the width property from the FW and
can't blindly rely on SFDP.
I've got a horrible
> feeling that the idiomatic thing is a combination of that and a bunch of
> per-device quirks. There may be a spec I'm not aware of though I'd be a
> bit surprised.
I'm not sure on that. I don't see anything in the ACPI spec.
I will note that PRP0001+"jedec,spi-nor" compatible DSD seems to be the
defacto method to describe the SPI NOR-compat part for ACPI - that's
what I'm using. We could add properties there, but that seems improper.
I'll continue to look....
More information about the linux-mtd