[PATCH 03/14] mtd: rawnand: gpmi: move all driver code into single file

Miquel Raynal miquel.raynal at bootlin.com
Wed Apr 17 03:23:50 PDT 2019


Hi Sascha,

Sascha Hauer <s.hauer at pengutronix.de> wrote on Tue,  9 Apr 2019
13:34:10 +0200:

> This moves the whole driver into a single C file. The filename gpmi-lib
> implies that it implements library functions, but in fact there are
> several cases where functions in gpmi-lib.c call back into functions in
> gpmi-nand.c. With this one has to constantly jump between those two
> files, so moving it into a single file improves readability, even when
> the file gets quite large.
> 
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> ---

Reviewed-by: Miquel Raynal <miquel.raynal at bootlin.com>


Thanks,
Miquèl



More information about the linux-mtd mailing list