[PATCH v3] mtd: cfi_cmdset_0002: Change write buffer to check correct value

Joakim Tjernlund Joakim.Tjernlund at infinera.com
Tue May 15 03:38:00 PDT 2018


On Tue, 2018-05-15 at 09:08 +0000, IKEGAMI Tokunori wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> 
> Hi Jocke-san,
> 
> Thank you so much for your comments.
> 
> > What goes on here, I think, is that the Toggle bit is not reliable and
> > adding chip_good()
> > basically tests DQ7 too.
> > If that is the case, one should only need chip_good(), have you tested
> > that?
> > 
> > In general I think toggle bit is awkward and moving to DQ7 would simply
> > things once
> > tests for other status bits are added.
> 
>   Yes you are right.
>   Since I have just confirmed that the flash write issue can be resolved by checking chip_good() only.
>   So I will do update the patch as so.

Then I got really curious, dos the same work for your erase problem?
Replace chip_ready(...) with chip_good(map, adr, map_word_ff(map) ?
Don't you have any status bits when erase/write fails?

 Jocke


More information about the linux-mtd mailing list