[PATCH v5 0/2] mtd: cfi_cmdset_0002: Changes to retry for flash erase

IKEGAMI Tokunori ikegami at allied-telesis.co.jp
Mon May 14 03:23:22 PDT 2018


Hi Boris-san,

Thanks for the comments.

> There's still a problem: the patches do not appear as a thread. Can you
> paste the git send-email command you use?

  The command that I used is below.
    git send-email v5-0000-cover-letter.patch v5-0001-mtd-cfi_cmdset_0002-Change-definition-naming-to-r.patch v5-0002-mtd-cfi_cmdset_0002-Change-erase-functions-to-ret.patch

  I thought that the patches are listed as a thread as below.
    <http://lists.infradead.org/pipermail/linux-mtd/2018-May/080950.html>

  Is this not mentioned by you probably?

> It seems that nothing has changed, so nothing more to review on my side.

  The changes themselves are not changed basically.

> And I'm still not entirely convinced by the fix, but if nobody complains, I'll apply it.

  Probably my explanation or investigation are not enough for you.
  If needed please let me know them I will do that.
    Note: In my understanding the investigation is enough.

  Anyway thank you so much for your reviewing.

> BTW, the changelog is really not clear, you should have something like:

  Very sorry about this let me list the change logs as below.
  Changes since v5:
  - Just fix the commit message of PATCH v4 2/2.
  - No changes for the source code diff.

  Changes since v4:
  - The patch series are just rebased since the coding style fix has been applied.

  Changes since v3:
  - Just fix the commit message of patch to retry the chip erase error.
  - Change the definition naming to MAX_RETRIES from MAX_WRITE_RETRIES.

  Changes since v2:
  - Split the v1 patch to separate as below.
    1. Fix coding style
    2. Change the definition naming
    3. Retry the erase error

  Changes since v1:
  - Initial patch to retry the chip erase error.

  Note: If needed I will do resend the patch series with the change log.
        So please let me know about this if so.

Regards,
Ikegami




More information about the linux-mtd mailing list