[PATCH] mtd: rawnand: add default values for dynamic timings

Miquel Raynal miquel.raynal at bootlin.com
Thu May 3 05:16:20 PDT 2018


Some timings like tBERS (block erase time), tCCs (change column setup
time), tPROG (page program time) and tR (page read time) are derived
from the ONFI parameter page. They are set in the SDR interface only
under certain circumstances: the chip is ONFI compliant and
->setup_data_interface() is populated.

The former makes the use of these timings unreliable if the driver uses
one of these four values with a non-ONFI chip, while the latter is a
problem for drivers not populating ->setup_data_interface() hook but
using these delays nonetheless in the code.

Fix this situation by taking the highest possible value for each
timing (stored as unsigned 16-bit entries in the parameter page).

This makes tBERS, tPROG and tR maximum times being ~65ms while typical
values are at most a few milliseconds. As these are timeouts, it is not
impacting at all on the performances in nominal use.

tCCS minimum time (delay to wait after a change column) becomes ~65us
while typical values are a few hundred nanoseconds. This might have an
impact depending on the driver's implementation.

Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
---
 drivers/mtd/nand/raw/nand_timings.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/mtd/nand/raw/nand_timings.c b/drivers/mtd/nand/raw/nand_timings.c
index 7c4e4a371bbc..848446f8004c 100644
--- a/drivers/mtd/nand/raw/nand_timings.c
+++ b/drivers/mtd/nand/raw/nand_timings.c
@@ -13,6 +13,8 @@
 #include <linux/export.h>
 #include <linux/mtd/rawnand.h>
 
+#define ONFI_DYN_TIMING_MAX U16_MAX
+
 static const struct nand_data_interface onfi_sdr_timings[] = {
 	/* Mode 0 */
 	{
@@ -24,6 +26,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
 			.tALH_min = 20000,
 			.tALS_min = 50000,
 			.tAR_min = 25000,
+			.tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
+			.tCCS_min = 1000UL * ONFI_DYN_TIMING_MAX,
 			.tCEA_max = 100000,
 			.tCEH_min = 20000,
 			.tCH_min = 20000,
@@ -38,6 +42,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
 			.tFEAT_max = 1000000,
 			.tIR_min = 10000,
 			.tITC_max = 1000000,
+			.tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
+			.tR_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
 			.tRC_min = 100000,
 			.tREA_max = 40000,
 			.tREH_min = 30000,
@@ -66,6 +72,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
 			.tALH_min = 10000,
 			.tALS_min = 25000,
 			.tAR_min = 10000,
+			.tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
+			.tCCS_min = 1000UL * ONFI_DYN_TIMING_MAX,
 			.tCEA_max = 45000,
 			.tCEH_min = 20000,
 			.tCH_min = 10000,
@@ -80,6 +88,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
 			.tFEAT_max = 1000000,
 			.tIR_min = 0,
 			.tITC_max = 1000000,
+			.tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
+			.tR_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
 			.tRC_min = 50000,
 			.tREA_max = 30000,
 			.tREH_min = 15000,
@@ -108,6 +118,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
 			.tALH_min = 10000,
 			.tALS_min = 15000,
 			.tAR_min = 10000,
+			.tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
+			.tCCS_min = 1000UL * ONFI_DYN_TIMING_MAX,
 			.tCEA_max = 30000,
 			.tCEH_min = 20000,
 			.tCH_min = 10000,
@@ -122,6 +134,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
 			.tFEAT_max = 1000000,
 			.tIR_min = 0,
 			.tITC_max = 1000000,
+			.tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
+			.tR_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
 			.tRC_min = 35000,
 			.tREA_max = 25000,
 			.tREH_min = 15000,
@@ -150,6 +164,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
 			.tALH_min = 5000,
 			.tALS_min = 10000,
 			.tAR_min = 10000,
+			.tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
+			.tCCS_min = 1000UL * ONFI_DYN_TIMING_MAX,
 			.tCEA_max = 25000,
 			.tCEH_min = 20000,
 			.tCH_min = 5000,
@@ -164,6 +180,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
 			.tFEAT_max = 1000000,
 			.tIR_min = 0,
 			.tITC_max = 1000000,
+			.tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
+			.tR_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
 			.tRC_min = 30000,
 			.tREA_max = 20000,
 			.tREH_min = 10000,
@@ -192,6 +210,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
 			.tALH_min = 5000,
 			.tALS_min = 10000,
 			.tAR_min = 10000,
+			.tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
+			.tCCS_min = 1000UL * ONFI_DYN_TIMING_MAX,
 			.tCEA_max = 25000,
 			.tCEH_min = 20000,
 			.tCH_min = 5000,
@@ -206,6 +226,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
 			.tFEAT_max = 1000000,
 			.tIR_min = 0,
 			.tITC_max = 1000000,
+			.tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
+			.tR_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
 			.tRC_min = 25000,
 			.tREA_max = 20000,
 			.tREH_min = 10000,
@@ -234,6 +256,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
 			.tALH_min = 5000,
 			.tALS_min = 10000,
 			.tAR_min = 10000,
+			.tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
+			.tCCS_min = 1000UL * ONFI_DYN_TIMING_MAX,
 			.tCEA_max = 25000,
 			.tCEH_min = 20000,
 			.tCH_min = 5000,
@@ -248,6 +272,8 @@ static const struct nand_data_interface onfi_sdr_timings[] = {
 			.tFEAT_max = 1000000,
 			.tIR_min = 0,
 			.tITC_max = 1000000,
+			.tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
+			.tR_max = 1000000ULL * ONFI_DYN_TIMING_MAX,
 			.tRC_min = 20000,
 			.tREA_max = 16000,
 			.tREH_min = 7000,
-- 
2.14.1




More information about the linux-mtd mailing list