[PATCH v2 00/16] Fix probe functions error path
Miquel Raynal
miquel.raynal at bootlin.com
Wed Mar 21 06:01:41 PDT 2018
Hello all,
In order to remove the limitation that prevents dynamic allocations
during the identification phase (nand_scan_ident()), we need to get rid
of the nand_scan_ident()/nand_scan_tail() calls from drivers and only
export nand_scan().
This series prepares the migration to nand_scan() by first fixing (and
enhancing some times) the probe function error path of the drivers that
do not use nand_scan() yet.
The three main problems addressed in the series are:
1/ a wrong error path that does not free/disable the resources
correctly.
2/ nand_cleanup() is not called upon error after a successful
nand_scan_tail().
3/ nand_release() is called instead of nand_cleanup(). nand_release()
does call nand_cleanup() and also mtd_device_unregister(), which
should not be called while mtd_device_register() as succeeded.
Thanks,
Miquèl
Changes since v1:
=================
* Extracted only the patches fixing the error path from the first huge
series (50+ patches) that also converted the drivers to nand_scan().
* Changed wrong nand_release() calls to nand_cleanup().
Miquel Raynal (16):
mtd: rawnand: brcmnand: fix probe function error path
mtd: rawnand: cafe: fix probe function error path
mtd: rawnand: davinci: fix probe function error path
mtd: rawnand: denali: fix probe function error path
mtd: rawnand: docg4: fix the probe function error path
mtd: rawnand: fsl_elbc: fix probe function error path
mtd: rawnand: fsl_ifc: fix probe function error path
mtd: rawnand: fsmc: fix and enhance probe function error path
mtd: rawnand: mxc: fix probe function error path
mtd: rawnand: omap2: fix the probe function error path
mtd: rawnand: sh_flctl: fix the probe function error path
mtd: rawnand: tango: fix probe function error path
mtd: rawnand: hisi504: fix and enhance the probe function error path
mtd: rawnand: lpc32xx_mlc: fix and enhance the probe function error
path
mtd: rawnand: lpc32xx_slc: fix and enhance the probe function error
path
mtd: rawnand: s3c2410: enhance the probe function error path
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 6 ++++-
drivers/mtd/nand/raw/cafe_nand.c | 18 +++++++++------
drivers/mtd/nand/raw/davinci_nand.c | 6 +++--
drivers/mtd/nand/raw/denali.c | 4 +++-
drivers/mtd/nand/raw/docg4.c | 22 +++++++++---------
drivers/mtd/nand/raw/fsl_elbc_nand.c | 9 ++++++--
drivers/mtd/nand/raw/fsl_ifc_nand.c | 8 ++++++-
drivers/mtd/nand/raw/fsmc_nand.c | 27 +++++++++++++----------
drivers/mtd/nand/raw/hisi504_nand.c | 35 ++++++++++-------------------
drivers/mtd/nand/raw/lpc32xx_mlc.c | 38 +++++++++++++++++---------------
drivers/mtd/nand/raw/lpc32xx_slc.c | 26 ++++++++++++----------
drivers/mtd/nand/raw/mxc_nand.c | 11 +++++----
drivers/mtd/nand/raw/omap2.c | 5 ++++-
drivers/mtd/nand/raw/s3c2410.c | 24 ++++++++++----------
drivers/mtd/nand/raw/sh_flctl.c | 4 ++++
drivers/mtd/nand/raw/tango_nand.c | 4 +++-
16 files changed, 140 insertions(+), 107 deletions(-)
--
2.14.1
More information about the linux-mtd
mailing list