[PATCH v8 0/3] mtd: rawnand: vf610_nfc: make use of ->exec_op()

Stefan Agner stefan at agner.ch
Mon Mar 19 15:24:13 PDT 2018


On 18.03.2018 22:18, Boris Brezillon wrote:
> On Sun, 18 Mar 2018 16:59:26 +0100
> Stefan Agner <stefan at agner.ch> wrote:
> 
>> Eighth revision of the rework patchset to use exec_op for NXP
>> Vybrid (and others) NAND Flash Controller.
>>
> 
> Already had fixed the problem locally, so I applied v7, which should be
> pretty much the same as your v8. Could you test nand/next or linux-next
> and let me know if there is a problem.
> 

Looks good to me, compiled and tested successfully too.

Thanks!

--
Stefan

> Thanks,
> 
> Boris
> 
>> --
>> Stefan
>>
>> Changes in v8:
>> - Check NAND status in vf610_nfc_write_page
>>
>> Changes in v7:
>> - (accidentally none)
>>
>> Changes in v6:
>> - Checkpatch style fixes
>> - Subject change
>>
>> Changes in v5:
>> - Fix COMMAND_NADDR_BYTES macro (fixes oob/page test issues)
>> - Renamed page_access to data_access
>> - Removed unclear debugging messages
>> - Introduce vf610_nfc_fill_row to avoid code duplication in
>>   vf610_nfc_(read|write)_page
>> - Add patch to enable ONFI SET/GET_FEATURES
>> - Comment/commit message fixes
>>
>> Changes in v4:
>> - Rebased to nand/next
>> - Simplify filling of address cycles
>> - Use accessors for SRAM (vf610_nfc_rd_from_sram/vf610_nfc_wr_to_sram)
>> - Use two op-parser patterns to avoid a single command reading and writing
>>   in a single operation
>> - Implement (read|write)_(page|oob)[_raw] to set page_access
>> - Set and clear vf610_nfc_ecc_mode in ecc (read|write)_page
>> - Clear/set 16-bit config when 16-bit bus is used and 8-bit access is
>>   requested
>>
>> Changes in v3:
>> - Separate exec_op() callback addition and removal of old callbacks
>> - Push data into regs in one function
>> - Readd op parser
>> - Implement custom read/write page for hardware ECC
>> - Rely on generic ecc.write_page_raw
>> - Use nand_read_oob_op instead of nand_read_page_op
>>
>> Stefan Agner (3):
>>   mtd: rawnand: vf610_nfc: make use of ->exec_op()
>>   mtd: rawnand: vf610_nfc: remove old hooks
>>   mtd: rawnand: vf610_nfc: support ONFI SET/GET_FEATURES commands
>>
>>  drivers/mtd/nand/raw/vf610_nfc.c | 632 +++++++++++++++++++++++----------------
>>  1 file changed, 380 insertions(+), 252 deletions(-)
>>



More information about the linux-mtd mailing list