[PATCH 2/2 v2] mtd: ubi: use put_device() if device_register fail
Arvind Yadav
arvind.yadav.cs at gmail.com
Thu Mar 15 00:20:31 PDT 2018
if device_register() returned an error! Always use put_device()
to give up the reference initialized.
Signed-off-by: Arvind Yadav <arvind.yadav.cs at gmail.com>
---
change in v2:
Fix use-after-free bug. move put_device() after cdev_del().
drivers/mtd/ubi/vmt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
index 3fd8d7f..93c6163 100644
--- a/drivers/mtd/ubi/vmt.c
+++ b/drivers/mtd/ubi/vmt.c
@@ -610,6 +610,7 @@ int ubi_add_volume(struct ubi_device *ubi, struct ubi_volume *vol)
out_cdev:
cdev_del(&vol->cdev);
+ put_device(&vol->dev);
return err;
}
--
1.9.1
More information about the linux-mtd
mailing list