[PATCH] mtd: chips: Replace printk() with pr_*() and define pr_fmt()

Andy Shevchenko andy.shevchenko at gmail.com
Tue Mar 13 09:28:13 PDT 2018


On Mon, Mar 12, 2018 at 7:02 PM, Arushi Singhal
<arushisinghal19971997 at gmail.com> wrote:
> Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>).
> This patch:


> @@ -182,7 +184,7 @@ static void fixup_convert_atmel_pri(struct mtd_info *mtd)

> -       printk(KERN_ERR "atmel Features: %02x\n", atmel_pri.Features);
> +       pr_err("atmel Features: %02x\n", atmel_pri.Features);

Does struct mtd_info include a pointer to struct device? In such case,
why not to use dev_*() macros instead?
(It's a question to the all current pr_*()/printk() calls.

-- 
With Best Regards,
Andy Shevchenko



More information about the linux-mtd mailing list