[PATCH v2 2/3] devres: Add devm_ioremap_shared_resource()
andy.shevchenko at gmail.com
Fri Jan 26 10:52:18 PST 2018
On Wed, Jan 24, 2018 at 7:15 PM, Ladislav Michl <ladis at linux-mips.org> wrote:
> On Wed, Jan 24, 2018 at 06:21:38PM +0200, Andy Shevchenko wrote:
>> > +#define devm_ioremap_resource(dev, res) \
>> > + __devm_ioremap_resource(dev, res, false)
>> > +#define devm_ioremap_shared_resource(dev, res) \
>> > + __devm_ioremap_resource(dev, res, true)
>> > +void __iomem *__devm_ioremap_resource(struct device *dev, struct resource *res,
>> > + bool shared);
>> I would rather do the following:
>> _resource() -> _resource_exclusive()
>> #define _resource() _resource_exclusive()
>> Add _resource_shared()
>> And use long names below in this file whenever refer to exclusive or
>> shared variant.
> Two separate functions were also considered, but I was unable to find small
> common implementation.
Common part is still like you have done.
I'm talking about _naming_ scheme here.
> If code size does not matter or you can provide a hint
> to make this solution small and nice, I'll go for it.
It would be the same as in your initial proposal, since I'm not
talking about duplicating anything.
With Best Regards,
More information about the linux-mtd