[PATCH v6 07/14] mtd: onenand: omap2: Account waiting time as waiting on IO

Ladislav Michl ladis at linux-mips.org
Fri Jan 12 05:14:54 PST 2018


Use wait_for_completion_io_timeout, which has an impact on how the
task is accounted in scheduling stats.

Signed-off-by: Ladislav Michl <ladis at linux-mips.org>
Reviewed-by: Peter Ujfalusi <peter.ujfalusi at ti.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel at collabora.co.uk>
Acked-by: Roger Quadros <rogerq at ti.com>
Tested-by: Tony Lindgren <tony at atomide.com>
Tested-by: Aaro Koskinen <aaro.koskinen at iki.fi>
---

Changes in v6: None
Changes in v5: None
Changes in v4:
- new patch

Changes in v3: None
Changes in v2: None

 drivers/mtd/onenand/omap2.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
index 883993bbe40b..0e7772e16d75 100644
--- a/drivers/mtd/onenand/omap2.c
+++ b/drivers/mtd/onenand/omap2.c
@@ -170,9 +170,8 @@ static int omap2_onenand_wait(struct mtd_info *mtd, int state)
 		if (result == 0) {
 			int retry_cnt = 0;
 retry:
-			result = wait_for_completion_timeout(&c->irq_done,
-						    msecs_to_jiffies(20));
-			if (result == 0) {
+			if (!wait_for_completion_io_timeout(&c->irq_done,
+						msecs_to_jiffies(20))) {
 				/* Timeout after 20ms */
 				ctrl = read_reg(c, ONENAND_REG_CTRL_STATUS);
 				if (ctrl & ONENAND_CTRL_ONGO &&
-- 
2.15.1




More information about the linux-mtd mailing list