[PATCH v2] mtd: tests: nandbiterrs: Fix read_page return value

Sascha Hauer s.hauer at pengutronix.de
Tue Jan 9 03:08:29 PST 2018


On Tue, Jan 09, 2018 at 10:51:08AM +0100, Boris Brezillon wrote:
> On Tue,  9 Jan 2018 10:47:02 +0100
> Sascha Hauer <s.hauer at pengutronix.de> wrote:
> 
> > The number of corrected bitflips is not correctly reported by
> > the test until the bitflip threshold is reached.
> > 
> > read_page() shall return the number of corrected bitflips, but
> > mtd_read() returns 0 or a negative error, so we can't forward
> > its return value. In the absence of an error we always have
> > calculate the number of bitflips ourselves.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> 
> I'll apply this patch, but you should really start using the userspace
> tests provided by mtd-utils, because I still plan to remove the
> in-kernel test modules at some point ;-).

Please do so. When I cannot find the in-kernel tests anymore I'll recall
that there are tests in userspace ;)

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the linux-mtd mailing list