[PATCH] mtd: tests: nandbiterrs: Fix read_page return value

[Sascha Hauer]

On Tue, Jan 09, 2018 at 10:31:12AM +0100, Boris Brezillon wrote:
> On Tue,  9 Jan 2018 10:09:38 +0100
> Sascha Hauer <s.hauer at pengutronix.de> wrote:
> 
> > The number of corrected bitflips is not correctly reported by
> > the test until the bitflip threshold is reached.
> > 
> > read_page() shall return the number of corrected bitflips, but
> > mtd_read() returns 0 or a negative error, so we can't forward
> > its return value. In the absence of an error we always have
> > calculate the number of bitflips ourselves.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> > ---
> >  drivers/mtd/tests/nandbiterrs.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/mtd/tests/nandbiterrs.c b/drivers/mtd/tests/nandbiterrs.c
> > index 5f03b8c885a9..11e39ab4a810 100644
> > --- a/drivers/mtd/tests/nandbiterrs.c
> > +++ b/drivers/mtd/tests/nandbiterrs.c
> > @@ -152,15 +152,16 @@ static int read_page(int log)
> >  
> >  	err = mtd_read(mtd, offset, mtd->writesize, &read, rbuffer);
> >  	if (err == -EUCLEAN)
> 
> Why not just replacing the above test by
> 
> 	if (!err || err == -EUCLEAN)

Looks better indeed. I just sent an update.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |