[PATCH 1/2] mtd: fsl-quadspi: update hwcaps read capabilities as READ_1_4_4

[Cyrille Pitchen]

Hi Yogesh,

Le 04/01/2018 à 12:12, Yogesh Gaur a écrit :
> Update Read capabilities as SNOR_HWCAPS_READ_1_4_4 i.e. Quad I/O cmd
> protocol. Spansion flash, s25fl512s, supports Quad read with read
> capabilities as 1-4-4.
> 
> Patch added support for SNOR_HWCAPS_READ_1_4_4 protocol.
> 
> Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur at nxp.com>
> ---
>  drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index c22e3eb..178e621 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -959,6 +959,7 @@ static int fsl_qspi_probe(struct platform_device *pdev)
>  {
>  	const struct spi_nor_hwcaps hwcaps = {
>  		.mask = SNOR_HWCAPS_READ_1_1_4 |
> +			SNOR_HWCAPS_READ_1_4_4 |

Sorry but I still don't agree on this patch: it should be squashed into
the patch adding a proper support to Fast Read 1-4-4 commands.

I understand this patch belongs to a series but even individual patches of
a series should not introduce bug. Like this, the spi_nor_scan() could
select the SPI 1-4-4 protocol for Fast Read operation.
However fsl_qspi_get_seqid() still only cares about the SPINOR_OP_READ_1_1_4
op code but not about the SPINOR_OP_READ_1_4_4. So it's not correct.

When looking for a bug, we need to be able to bissect. However testing right
after this patch would fail with SPI flash memories supporting Fast Read
1-4-4.

Best regards,

Cyrille

>  			SNOR_HWCAPS_PP,
>  	};
>  	struct device_node *np = pdev->dev.of_node;
>