[PATCH 1/2] mtd: qcom_nandc: Add a NULL check for devm_kasprintf()
Boris Brezillon
boris.brezillon at free-electrons.com
Sun Jan 7 02:04:59 PST 2018
On Fri, 5 Jan 2018 18:02:55 -0200
Fabio Estevam <festevam at gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam at nxp.com>
>
> devm_kasprintf() may fail, so we should better add a NULL check
> and propagate an error on failure.
Applied (also fixed the subject prefix).
Thanks,
Boris
>
> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
> ---
> drivers/mtd/nand/qcom_nandc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c
> index 245d0f3..3fe2ff8 100644
> --- a/drivers/mtd/nand/qcom_nandc.c
> +++ b/drivers/mtd/nand/qcom_nandc.c
> @@ -2639,6 +2639,8 @@ static int qcom_nand_host_init(struct qcom_nand_controller *nandc,
>
> nand_set_flash_node(chip, dn);
> mtd->name = devm_kasprintf(dev, GFP_KERNEL, "qcom_nand.%d", host->cs);
> + if (!mtd->name)
> + return -ENOMEM;
> mtd->owner = THIS_MODULE;
> mtd->dev.parent = dev;
>
More information about the linux-mtd
mailing list