[PATCH 2/2] mtdconcat: Improve a size determination in concat_erase()

SF Markus Elfring elfring at users.sourceforge.net
Thu Jan 4 11:30:49 PST 2018


From: Markus Elfring <elfring at users.sourceforge.net>
Date: Thu, 4 Jan 2018 20:00:27 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>
---
 drivers/mtd/mtdconcat.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mtd/mtdconcat.c b/drivers/mtd/mtdconcat.c
index f1a60c55a126..67d39e562c0f 100644
--- a/drivers/mtd/mtdconcat.c
+++ b/drivers/mtd/mtdconcat.c
@@ -428,8 +428,7 @@ static int concat_erase(struct mtd_info *mtd, struct erase_info *instr)
 	}
 
 	/* make a local copy of instr to avoid modifying the caller's struct */
-	erase = kmalloc(sizeof (struct erase_info), GFP_KERNEL);
-
+	erase = kmalloc(sizeof(*erase), GFP_KERNEL);
 	if (!erase)
 		return -ENOMEM;
 
-- 
2.15.1




More information about the linux-mtd mailing list