[PATCH] mtd: fsl-quadspi: update hwcaps read capabilities as READ_1_4_4

[Yogesh Narayan Gaur]

Hello Cyrille,

My mistake, I was planning to send this patch along with the patch
https://patchwork.ozlabs.org/patch/854967/ in which have done changes in fsl-quadspi.c driver to have run-time LUT creation support.

Apologies for that.

Would send new patch series, marking these as v1, v2.

--
Regards
Yogesh Gaur.

> -----Original Message-----
> From: Cyrille Pitchen [mailto:cyrille.pitchen at wedev4u.fr]
> Sent: Thursday, January 04, 2018 1:37 AM
> To: Yogesh Narayan Gaur <yogeshnarayan.gaur at nxp.com>; linux-
> mtd at lists.infradead.org
> Cc: boris.brezillon at free-electrons.com; computersforpeace at gmail.com; Han
> Xu <han.xu at nxp.com>; festevam at gmail.com; Prabhakar Kushwaha
> <prabhakar.kushwaha at nxp.com>; Suresh Gupta <suresh.gupta at nxp.com>
> Subject: Re: [PATCH] mtd: fsl-quadspi: update hwcaps read capabilities as
> READ_1_4_4
> 
> Le 03/01/2018 à 11:56, Yogesh Gaur a écrit :
> > Update Read capabilities as SNOR_HWCAPS_READ_1_4_4 i.e. Quad I/O cmd
> > protocol. Spansion flash, s25fl512s, supports Quad read with read
> > capabilities as 1-4-4.
> >
> > Patch added support for SNOR_HWCAPS_READ_1_4_4 protocol.
> >
> > Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur at nxp.com>
> > ---
> >  drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c
> > b/drivers/mtd/spi-nor/fsl-quadspi.c
> > index c22e3eb..178e621 100644
> > --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> > +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> > @@ -959,6 +959,7 @@ static int fsl_qspi_probe(struct platform_device
> > *pdev)  {
> >  	const struct spi_nor_hwcaps hwcaps = {
> >  		.mask = SNOR_HWCAPS_READ_1_1_4 |
> > +			SNOR_HWCAPS_READ_1_4_4 |
> >  			SNOR_HWCAPS_PP,
> >  	};
> >  	struct device_node *np = pdev->dev.of_node;
> >
> 
> NACK: adding the SNOR_HWCAPS_READ_1_4_4 hardware capability tells
> spi_nor_scan() that the SPI (flash) controller, not the SPI flash memory, supports
> the SPI 1-4-4 for Fast Read operations.
> 
> You cannot add this flag without adding real support of Fast Read 1-4-4 to the
> fsl-quadspi.c driver.