[PATCH NAND 0/5] Replace printk statements with pr_*macros

[Ezequiel Garcia]

Hi Shreeya,

Thanks for the contribution.

On 16 February 2018 at 13:50, Shreeya Patel
<shreeya.patel23498 at gmail.com> wrote:
> This patchset removes all the log levels i.e. KERN_WARN,
> KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk
> statements and replaces the printk statements with appropriate
> pr_*macros.
> According to the kernel coding style, pr_*macro is the preferred
> way to print the message.
>

So, two things to begin with.

First of all, despite this contribution being part of outreachy,
I believe you can include mailing lists in your case.

In other words, don't use the "nol" option in get_maintainer
script and Cc the MTD mailing list: linux-mtd at lists.infradead.org.

>
> Shreeya Patel (5):
>   mtd/nand: Replace printk with pr_warn
>   mtd/nand: Replace printk with pr_notice
>   mtd/nand: Replace printk with pr_err
>   mtd/nand: Replace printk with pr_info
>   mtd/nand: Replace printk with pr_debug
>

This is a non-usual split. We usually split patches per-driver,
instead of grouping all the pr_{} of a given type together.

Can you re-do the series? Grouping the changes per-driver,
i.e. all the pr_{} changes in cafe_nand.c together, and so on.

>  drivers/mtd/nand/ams-delta.c     |  4 +--
>  drivers/mtd/nand/cafe_nand.c     |  4 +--
>  drivers/mtd/nand/cs553x_nand.c   |  8 ++---
>  drivers/mtd/nand/diskonchip.c    | 76 +++++++++++++++++++++-------------------
>  drivers/mtd/nand/fsl_elbc_nand.c |  4 +--
>  drivers/mtd/nand/fsl_ifc_nand.c  |  2 +-
>  drivers/mtd/nand/mxc_nand.c      |  2 +-
>  drivers/mtd/nand/nand_bch.c      | 12 +++----
>  drivers/mtd/nand/nandsim.c       | 10 +++---
>  drivers/mtd/nand/r852.c          |  2 +-
>  drivers/mtd/nand/r852.h          |  6 ++--
>  drivers/mtd/nand/sh_flctl.c      |  2 +-
>  drivers/mtd/nand/sm_common.c     |  5 ++-
>  13 files changed, 70 insertions(+), 67 deletions(-)
>
> --
> 2.7.4
>



-- 
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar