[PATCH 3/6] mtd: nand: mxc: Remove useless checks in GET/SET_FEATURES functions
Miquel Raynal
miquel.raynal at bootlin.com
Sat Feb 3 01:55:41 PST 2018
From: Miquel Raynal <miquel.raynal at free-electrons.com>
All the calls to the chip's hooks ->onfi_get/set_features() go through
the core's wrappers nand_get/set_features() that already do the
necessary checks about ONFI compliance and feature support. Remove these
checks from the mxc's functions.
Signed-off-by: Miquel Raynal <miquel.raynal at free-electrons.com>
---
drivers/mtd/nand/mxc_nand.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index f3be0b2a8869..e36f6ae50bdd 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -1324,11 +1324,6 @@ static int mxc_nand_onfi_set_features(struct mtd_info *mtd,
struct mxc_nand_host *host = nand_get_controller_data(nand_chip);
int i;
- if (!chip->onfi_version ||
- !(le16_to_cpu(chip->onfi_params.opt_cmd)
- & ONFI_OPT_CMD_SET_GET_FEATURES))
- return -EINVAL;
-
host->buf_start = 0;
for (i = 0; i < ONFI_SUBFEATURE_PARAM_LEN; ++i)
@@ -1350,11 +1345,6 @@ static int mxc_nand_onfi_get_features(struct mtd_info *mtd,
struct mxc_nand_host *host = nand_get_controller_data(nand_chip);
int i;
- if (!chip->onfi_version ||
- !(le16_to_cpu(chip->onfi_params.opt_cmd)
- & ONFI_OPT_CMD_SET_GET_FEATURES))
- return -EINVAL;
-
host->devtype_data->send_cmd(host, NAND_CMD_GET_FEATURES, false);
mxc_do_addr_cycle(mtd, addr, -1);
host->devtype_data->send_page(mtd, NFC_OUTPUT);
--
2.14.1
More information about the linux-mtd
mailing list