[PATCH 0/3] Changes in Marvell NAND controller DT parsing code

Miquel Raynal miquel.raynal at bootlin.com
Wed Apr 25 07:13:13 PDT 2018


Hi Boris,

On Wed, 25 Apr 2018 15:20:07 +0200, Boris Brezillon
<boris.brezillon at bootlin.com> wrote:

> Hi Miquel,
> 
> On Wed, 25 Apr 2018 14:53:28 +0200
> Miquel Raynal <miquel.raynal at bootlin.com> wrote:
> 
> > Hello,
> > 
> > At first I just wanted to send a fix to avoid timeouts at boot time when
> > using old bindings (harmless):
> > 
> > [    1.367460] marvell-nfc f2720000.nand: Timeout on CMDD (NDSR: 0x00000080)
> > [    1.474292] marvell-nfc f2720000.nand: Timeout on CMDD (NDSR: 0x00000280)
> > 
> > This is addressed in the first patch and comes from the DT parsing of
> > the number of Chip Select lines.
> > 
> > While working on it, Boris pointed another issue with the 'num-cs'
> > property (legacy bindings) in some code that should not exist anyway. I
> > removed that code in patch 2.
> > 
> > Finally, while writing the second patch, I discovered a better way to handle
> > the code besides (that handles the CS count for new bindings) by using
> > of_property_count_elems_of_size(). Patch 3 makes the switch.
> > 
> > Regards,
> > Miquèl
> > 
> > 
> > Miquel Raynal (3):
> >   mtd: rawnand: marvell: fix the chip-select DT parsing logic
> >   mtd: rawnand: marvell: fix CS pin count with old bindings
> >   mtd: rawnand: marvell: use OF helper to read a property element count  
> 
> I usually ask people to properly split their changes, but this time I'd
> prefer to have everything in a single patch so that I can queue it to
> the fixes branch.

That's sad :) but sure, I'll squash all of that.

Thanks,
Miquèl

> 
> Regards,
> 
> Boris
> 



-- 
Miquel Raynal, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the linux-mtd mailing list