[PATCH v3 09/11] mtd: rawnand: lpc32xx_mlc: fix the probe function error path
Miquel Raynal
miquel.raynal at bootlin.com
Sat Apr 21 11:00:41 PDT 2018
An error after nand_scan_tail() should trigger a nand_cleanup() and not
a nand_release(). The latter doing an mtd_device_unregister() which is
not needed if mtd_device_register() failed.
Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
---
drivers/mtd/nand/raw/lpc32xx_mlc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/lpc32xx_mlc.c b/drivers/mtd/nand/raw/lpc32xx_mlc.c
index 6e31faf2f07f..052d123a8304 100644
--- a/drivers/mtd/nand/raw/lpc32xx_mlc.c
+++ b/drivers/mtd/nand/raw/lpc32xx_mlc.c
@@ -806,12 +806,12 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
res = mtd_device_register(mtd, host->ncfg->parts,
host->ncfg->num_parts);
if (res)
- goto release_nand;
+ goto cleanup_nand;
return 0;
-release_nand:
- nand_release(mtd);
+cleanup_nand:
+ nand_cleanup(nand_chip);
free_irq:
free_irq(host->irq, host);
release_dma_chan:
--
2.14.1
More information about the linux-mtd
mailing list