[PATCH 11/18] mtd: rawnand: gpmi: instantiate cmdfunc

Boris Brezillon boris.brezillon at bootlin.com
Fri Apr 20 13:38:45 PDT 2018

Hi Sam, Arnout,

On Fri, 20 Apr 2018 10:19:39 +0200
Sam Lefebvre <sam.lefebvre at essensium.com> wrote:

> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout at mind.be>
> Later patches will optimize the command handling for gpmi. This
> requires a gpmmi-specific implementation of cmdfunc. As a first step,
> nand_command() is copied literally from nand_base.c (after merging
> nand_command() and nand_command_lp()).

NACK. As said in my review of patch 10, we're trying to move a many
drivers as possible to the ->exec_op() approach in order to ease
maintenance of the NAND subsystem. What you're doing here is going in
the wrong direction.

Please work on a solution based on ->exec_op().



More information about the linux-mtd mailing list