[PATCH 1/2] mtd: spi-nor: fix style issue

Cyrille Pitchen cyrille.pitchen at wedev4u.fr
Sun Oct 29 12:54:04 PDT 2017


Hi Philipp

Le 19/10/2017 à 10:12, Philipp Puschmann a écrit :
> Fixed a space coding style issue, found via checkpatch.
> 
> Signed-off-by: Philipp Puschmann <pp at emlix.com>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 19c000722cbc..386de64e5a86 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -964,7 +964,7 @@ static const struct flash_info spi_nor_ids[] = {
>  	{ "f25l64qa", INFO(0x8c4117, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_HAS_LOCK) },
>  
>  	/* Everspin */
> -	{ "mr25h256", CAT25_INFO( 32 * 1024, 1, 256, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
> +	{ "mr25h256", CAT25_INFO(32 * 1024, 1, 256, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },

Indeed, submitted patches should always pass the checkpatch test but
let's say entries of the spi_nor_ids[] are are exceptions here: it is
more easy to read if data are aligned hence I won't apply this patch.

Best regards,

Cyrille

>  	{ "mr25h10",  CAT25_INFO(128 * 1024, 1, 256, 3, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
>  	{ "mr25h40",  CAT25_INFO(512 * 1024, 1, 256, 3, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
>  
> 




More information about the linux-mtd mailing list