[PATCH] mtd: nand: omap2: Do not assign omap_nand_info to platform drvdata

Boris Brezillon boris.brezillon at free-electrons.com
Sat Oct 14 08:11:23 PDT 2017


On Tue, 10 Oct 2017 15:32:45 +0200
Ladislav Michl <ladis at linux-mips.org> wrote:

> commit 67ce04bf2746 ("mtd: nand: add OMAP2/OMAP3 NAND driver") assigned
> pointer to omap_nand_info to the platform drvdata in probe function
> just to be reasigned later to the pointer to mtd_info, which is
> what remove function expects it to be. Remove useless assignment.
> 

Applied.

Thanks,

Boris

> Signed-off-by: Ladislav Michl <ladis at linux-mips.org>
> ---
>  drivers/mtd/nand/omap2.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 01368a8f9e3f..a97c1aeed55e 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1823,7 +1823,6 @@ static int omap_nand_probe(struct platform_device *pdev)
>  	if (err)
>  		return err;
>  
> -	platform_set_drvdata(pdev, info);
>  	info->ops = gpmc_omap_get_nand_ops(&info->reg, info->gpmc_cs);
>  	if (!info->ops) {
>  		dev_err(&pdev->dev, "Failed to get GPMC->NAND interface\n");




More information about the linux-mtd mailing list