[RFC PATCH v2 1/6] mtd: nand: provide several helpers to do common NAND operations
Masahiro Yamada
yamada.masahiro at socionext.com
Thu Nov 30 02:38:15 PST 2017
Hi Boris,
2017-11-30 17:18 GMT+09:00 Boris Brezillon <boris.brezillon at free-electrons.com>:
>>
>> Theoretically, there could be three cases:
>> [1] INTR__ERASE_COMP interrupt is asserted
>> [2] INTR__ERASE_FAIL interrupt is asserted
>> [3] Nothing is asserted (bailout by timeout)
>
> Well, ideally we should have something like:
>
> if (irq_status & INTR__ERASE_COMP)
> return 0;
> else if (irq_status & INTR__ERASE_FAIL)
> return -EIO;
>
> return -ETIMEDOUT;
>
> But let's keep the existing behavior (return -EIO in case of timeout).
>
I agree with this change,
but it should also be done in a separate work.
--
Best Regards
Masahiro Yamada
More information about the linux-mtd
mailing list