[PATCH 2/2] libubigen: No need to calculate crc for each ubi_vtbl_record

David Oberhollenzer david.oberhollenzer at sigma-star.at
Sat Nov 18 05:26:00 PST 2017


Hi!

Sorry for the delayed reply. Apart from being busy, I was a bit hesitant with this patch
as it wasn't immediately obvious to me what you are trying to accomplish here.

I can see the point of the patch. Since vtbl has all entries initialized to 0, the CRC
should be the same for all and it should be sufficient to calculate it just for the first
entry and then copy it.

But is there any actual issue you are trying to resolve or is it just some micro
optimization? I can hardly imagine any significant performance gain from this and
AFAIK the code works right now as is.

Also, the patch seems to be broken (some kind of white space mangling?) and doesn't
apply on my end.


Thanks,

David




More information about the linux-mtd mailing list