[PATCH] mtd: nand: mtk: deselect the chip that was selected in resume function
Boris Brezillon
boris.brezillon at free-electrons.com
Wed Nov 1 03:00:21 PDT 2017
Hi Xiaolei,
On Wed, 1 Nov 2017 14:19:57 +0800
<xiaolei.li at mediatek.com> wrote:
> From: Xiaolei Li <xiaolei.li at mediatek.com>
>
> It is necessary to deselect the chip if it was selected before.
> But now we only select chips when resume nand driver.
> So, deselect the chip after doing nand reset.
>
> Signed-off-by: Xiaolei Li <xiaolei.li at mediatek.com>
> ---
> drivers/mtd/nand/mtk_nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/mtk_nand.c b/drivers/mtd/nand/mtk_nand.c
> index d86a7d1..a8bf61a 100644
> --- a/drivers/mtd/nand/mtk_nand.c
> +++ b/drivers/mtd/nand/mtk_nand.c
> @@ -1557,6 +1557,7 @@ static int mtk_nfc_resume(struct device *dev)
> for (i = 0; i < chip->nsels; i++) {
> nand->select_chip(mtd, i);
> nand->cmdfunc(mtd, NAND_CMD_RESET, -1, -1);
> + nand->select_chip(mtd, -1);
Can you use nand_reset() instead of open-coding this sequence?
Thanks,
Boris
> }
> }
>
More information about the linux-mtd
mailing list