[PATCH] mkfs.ubifs: Add support for symlinks in device table

David Engraf david.engraf at sysgo.com
Fri May 19 01:47:45 PDT 2017


Hi Richard,

Am 19.05.2017 um 10:24 schrieb Richard Weinberger:
> David,
> 
> Am 19.05.2017 um 08:13 schrieb David Engraf:
>>> Do you only care about the ls output or does one of your applications
>>> depend on it?
>>
>> It's mainly the output of ls because I'm using a verify script checking ownership of each file. Without having the ability to set the ownership of symlinks it will fail because ls
>> returns a uid/gid of my host development system which is not valid on the target.
> 
> this makes sense.
> 
> Please also massage this comment in devtable.c:
>   * Don't bother with symlinks (permissions are irrelevant), hard links (special
>   * cases of regular files), or sockets (why bother).

Okay.

> and make sure that the permissions are not set for symlinks.
> Otherwise I'd give users the impression that symlinks have permissions.

You mean the mode should be ignore in the device table for symlinks. 
This means the mode is taken from the original file and stored in the 
ubifs inode (add_inode()). This would be okay for me but what is ubifs 
doing with this information stored in its inode?

We could also force symlinks to 777 and return an error if the user 
tries to use a different value. What do you think?

Best regards
- David




More information about the linux-mtd mailing list