[PATCH] mtd: nand: orion: don't complain for probe deferral

Brian Norris computersforpeace at gmail.com
Mon May 8 10:46:22 PDT 2017

On Tue, May 02, 2017 at 10:07:31AM +0200, Simon Baatz wrote:
> Hi Brian,
> On Mon, May 01, 2017 at 05:04:54PM -0700, Brian Norris wrote:
> > Recent patches to this driver changed the error handling for missing
> > clocks. Now we'll print an error if the clock causes us to defer
> > probing. Let's not do that.
> > 
> This is by intention.  Probe deferral is not supported by drivers
> using module_platform_driver_probe().  EPROBE_DEFER results in not
> being able to get the clock and, thus, is handled like any other
> error.

Ah, good point. I overlooked that part.

Seems kind of inconsistent driver writing (what happens if someone wants
to use this driver on a more complex system, where some of the dependent
resources are not available at init time?), but I see in the git logs
that apparently this is intentional (to save memory?).

So, I'll NAK this patch.


More information about the linux-mtd mailing list