[PATCH] mtd: nand: jz4780: Use mtd_set_ooblayout() to set the ooblayout

Harvey Hunt harveyhuntnexus at gmail.com
Wed May 3 10:32:47 PDT 2017


Hi Boris,

On 05/02/2017 11:29 AM, Boris Brezillon wrote:
> The mtd_set_ooblayout() accesor has been added to hide internals of
> mtd_info and ease future refactoring. Call mtd_set_ooblayout() instead of
> directly accessing mtd->ooblayout.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> ---
>   drivers/mtd/nand/jz4780_nand.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/jz4780_nand.c b/drivers/mtd/nand/jz4780_nand.c
> index a39bb70175ee..8bc835f71b26 100644
> --- a/drivers/mtd/nand/jz4780_nand.c
> +++ b/drivers/mtd/nand/jz4780_nand.c
> @@ -205,7 +205,7 @@ static int jz4780_nand_init_ecc(struct jz4780_nand_chip *nand, struct device *de
>   		return -EINVAL;
>   	}
>   
> -	mtd->ooblayout = &nand_ooblayout_lp_ops;
> +	mtd_set_ooblayout(mtd, &nand_ooblayout_lp_ops);
>   
>   	return 0;
>   }
> 

Looks good to me.

Acked-by: Harvey Hunt <harveyhuntnexus at gmail.com>

Thanks,

Harvey



More information about the linux-mtd mailing list