[PATCH] mtd: nand: samsung: warn about un-parseable ECC info
Boris Brezillon
boris.brezillon at free-electrons.com
Tue May 2 00:57:06 PDT 2017
On Mon, 1 May 2017 17:04:55 -0700
Brian Norris <computersforpeace at gmail.com> wrote:
> We don't handle cases larger than 7. We probably shouldn't pretend we
> know the ECC step size in this case, and it's probably also good to
> WARN() like we do in many other similar cases.
>
> Cc: Hans de Goede <hdegoede at redhat.com>
> Fixes: 8fc82d456e40 ("mtd: nand: samsung: Retrieve ECC requirements from extended ID")
> Signed-off-by: Brian Norris <computersforpeace at gmail.com>
Acked-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> ---
> Compile tested only
>
> drivers/mtd/nand/nand_samsung.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/nand/nand_samsung.c b/drivers/mtd/nand/nand_samsung.c
> index 9cfc4035a420..1e0755997762 100644
> --- a/drivers/mtd/nand/nand_samsung.c
> +++ b/drivers/mtd/nand/nand_samsung.c
> @@ -84,6 +84,9 @@ static void samsung_nand_decode_id(struct nand_chip *chip)
> case 7:
> chip->ecc_strength_ds = 60;
> break;
> + default:
> + WARN(1, "Could not decode ECC info");
> + chip->ecc_step_ds = 0;
> }
> }
> } else {
More information about the linux-mtd
mailing list